Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create MongoDB v3.6 with azurerm_cosmosdb_account (#4757) #5325

Merged
merged 2 commits into from
Jan 20, 2020
Merged

Create MongoDB v3.6 with azurerm_cosmosdb_account (#4757) #5325

merged 2 commits into from
Jan 20, 2020

Conversation

aristosvo
Copy link
Collaborator

@aristosvo aristosvo commented Jan 7, 2020 •
edited
Loading

Fixes #4757 for service/cosmosdb

FWIW, in #4757 are also validations mentioned. I'm looking into implementing these, but I'm not sure wheter these should be here in a custom validate function or not. If they should be here, the question is if I should break the existing contract to implement these (with more validations) in the schema:

"capabilities": {
	Type:     schema.TypeSet,
	Optional: true,
	Elem: &schema.Resource{
		Schema: map[string]*schema.Schema{
			"EnableMongo": {
				Type:     schema.TypeBool,
				Optional: true,
				Default:  false,
			},
..

@ghost ghost added the size/S label Jan 7, 2020
@ghost ghost added the documentation label Jan 7, 2020
@dany74q
Copy link

dany74q commented Jan 19, 2020

Awesome ! Any idea when this is going to be merged ?
We can't create cosmos accounts w/ the 3.6 backend without this change.

@aristosvo
Copy link
Collaborator Author

@katbyte can you give us an indication when you have time for a review? It are just a few lines of code.

@dany74q I’m using it already myself based on my custom build, I can send it to you if you’d like that or follow the instructions in the repository.

katbyte
katbyte approved these changes Jan 20, 2020
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @aristosvo,

Thanks for the PR. This LGTM 🚀

azurerm/internal/services/cosmos/resource_arm_cosmosdb_account.go
@@ -211,6 +211,7 @@ func resourceArmCosmosDbAccount() *schema.Resource {
"EnableTable",
"EnableGremlin",
"EnableCassandra",
"EnableMongo",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we get a test that sets this value??

@katbyte katbyte added this to the v1.42.0 milestone Jan 20, 2020
@katbyte katbyte merged commit c3a9874 into hashicorp:master Jan 20, 2020
@katbyte
Copy link
Collaborator

katbyte commented Jan 20, 2020

@aristosvo, wrt validations I really like your idea of adding boolean properties to the capabilities block, however that would be a breaking change that should be done for 2.0.

katbyte added a commit that referenced this pull request Jan 20, 2020
@katbyte
Update CHANGELOG.md to include #5325
1c0ec99
@ghost
Copy link

ghost commented Jan 27, 2020

This has been released in version 1.42.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.42.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
documentation enhancement service/cosmosdb size/S
Projects
None yet
Milestone
v1.42.0
Development

Successfully merging this pull request may close these issues.

Create MongoDB v3.6 with azurerm_cosmosdb_account
4 participants
@aristosvo @dany74q @katbyte @tombuildsstuff